Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Multikey support #1316

Merged
merged 2 commits into from
Jan 19, 2024
Merged

feat: add Multikey support #1316

merged 2 commits into from
Jan 19, 2024

Conversation

mirceanis
Copy link
Member

What is being changed

This PR upgrades did-jwt, did-jwt-vc and @aviarytech/did-peer dependencies.
The update fixes issues with did:peer identifiers that use multiple service endpoints as well as adding support for Multikey verification methods.

The updated libs also allowed the simplification of some codepaths that involved checking the key type and the fixing of some corner cases where the wrong key types were mistakenly used (like using secp256k1 for encryption).

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Details

See:

* upgrade did:peer provider
* upgrade did-jwt to v8
* simplify key extraction, and key comparison code
* Multikey / JsonWebKey2020 processing is done by did-jwt
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (c050588) 85.47% compared to head (40ad8ef) 85.50%.

Files Patch % Lines
packages/utils/src/did-utils.ts 65.51% 10 Missing ⚠️
packages/utils/src/jwk-did-utils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1316      +/-   ##
==========================================
+ Coverage   85.47%   85.50%   +0.03%     
==========================================
  Files         170      170              
  Lines       18952    18946       -6     
  Branches     2116     2115       -1     
==========================================
+ Hits        16199    16200       +1     
+ Misses       2753     2746       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirceanis mirceanis merged commit 165de35 into next Jan 19, 2024
10 checks passed
@mirceanis mirceanis deleted the did-peer-upgrade branch January 19, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants