Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add support for did:jwk and did:peer to CLI #1320

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

fixes #1319

What is being changed

The default CLI config gets an update to support creating and resolving did:jwk and did:peer.
The CLI package gets 2 new plugin dependencies for these DID methods.
The PeerDidProvider is more lenient about num_algo parameters for creation. It will default to 0 if nothing is provided.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (165de35) 85.50% compared to head (8689e0b) 85.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1320   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files         170      170           
  Lines       18946    18947    +1     
  Branches     2115     2120    +5     
=======================================
+ Hits        16200    16201    +1     
  Misses       2746     2746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirceanis mirceanis merged commit 3ac343e into next Jan 22, 2024
9 checks passed
@mirceanis mirceanis deleted the add-did-jwk-to-cli branch January 22, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] add did:jwk and did:peer to the default CLI config
3 participants