Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credential-ld): let verifiers use all supported verification methods #1331

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

fixes #1329

What is being changed

The VeramoLdSignature.getSupportedVerificationType() can now return string[] as well as string
This allows VeramoLdSignature suite implementations to signal compatibility with multiple Verification Method types for verification.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

The `VeramoLdSignature.getSupportedVerificationType()` can now return `string[]` as well as `string`

fixes #1329
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7896cea) 89.83% compared to head (cde68aa) 89.83%.

Files Patch % Lines
...s/credential-ld/src/suites/JsonWebSignature2020.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1331   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files         176      176           
  Lines       27010    27017    +7     
  Branches     2120     2124    +4     
=======================================
+ Hits        24265    24272    +7     
  Misses       2745     2745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirceanis mirceanis merged commit aa95af0 into next Jan 26, 2024
9 checks passed
@mirceanis mirceanis deleted the 1329-ld-suite-verification-options branch January 26, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Veramo LD suites can only signal support for a single type of Verification Method
4 participants