fix(credential-eip712): chainId for any did method #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1334 +/- ##
==========================================
- Coverage 89.84% 89.83% -0.02%
==========================================
Files 176 176
Lines 27278 27285 +7
Branches 2164 2164
==========================================
+ Hits 24509 24512 +3
- Misses 2769 2773 +4 ☔ View full report in Codecov by Sentry. |
stanleyyconsensys
suggested changes
Jan 30, 2024
| @@ -161,7 +161,7 @@ export function getEthereumAddress(verificationMethod: VerificationMethod): stri | |||
| * | |||
| * @beta This API may change without a BREAKING CHANGE notice. | |||
| */ | |||
| export function getChainIdForDidEthr(verificationMethod: _NormalizedVerificationMethod): number { | |||
| export function getChainId(verificationMethod: _NormalizedVerificationMethod): number { | |||
| if (verificationMethod.blockchainAccountId?.includes('@eip155')) { | |||
There was a problem hiding this comment.
may be we can also add is NAN as the parseInt result
if it is nan, then throw error, hence the Eip712 fallback to use chainId 1?
mirceanis
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Looks good.
It is worth handling the NaN case that @stanleyyconsensys mentioned.
The test would be against a malformed blockchainAccountId:
eip155:0xe708:0x197...
eip155:linea:0x197...
0x197...@eip155:0xe708
0x197...@eip155:linea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
Getting correct chainId for any did method
Quality
Check all that apply:
pnpm i,pnpm build,pnpm test,pnpm test:browserlocally.