Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove interactive prompting on CLI execute command #1347

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Feb 22, 2024

What issue is this PR fixing

fixes #1281

What is being changed

When calling veramo execute without parameters, the CLI will no longer offer a list of available methods based on oas-resolver.

Also, the execute command is now using Debug instead of console.log for logging, so that the console can be used for stdout and piping. Example: veramo execute -m didManagerFind -a '{}' | jq '.[0].did' to get the DID of the first identifier managed locally.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because there is still no test harness for CLI, and I am aware that a PR without tests will likely get rejected.

Details

The discussion in #1281 lead to the decision to remove this functionality from the CLI

@mirceanis mirceanis added the CLI issues concerning the Veramo command line tool label Feb 22, 2024
using Debug instead of `console.log` for logging, so that the console can be used for stdout.

fixes #1281
@mirceanis mirceanis force-pushed the 1281-stack-overflow-on-cli-execute branch from b78e02f to fcee4ae Compare February 22, 2024 11:48
@mirceanis mirceanis added this to the v6 milestone Feb 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5375bd) 89.83% compared to head (fcee4ae) 89.83%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1347   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files         176      176           
  Lines       27292    27292           
  Branches     2166     2166           
=======================================
  Hits        24517    24517           
  Misses       2775     2775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickreynolds nickreynolds merged commit d8e2167 into next Feb 22, 2024
9 checks passed
@nickreynolds nickreynolds deleted the 1281-stack-overflow-on-cli-execute branch February 22, 2024 17:31
mirceanis added a commit that referenced this pull request Feb 22, 2024
using Debug instead of `console.log` for logging, so that the console can be used for stdout.

fixes #1281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI issues concerning the Veramo command line tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli veramo execute ... fails with Maximum call stack size exceeded
3 participants