Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent install still opens README #119

Closed
ThreeDeeJay opened this issue Jun 3, 2021 · 4 comments
Closed

Silent install still opens README #119

ThreeDeeJay opened this issue Jun 3, 2021 · 4 comments
Labels
Milestone

Comments

@ThreeDeeJay
Copy link
Contributor

Just noticed silent install opens the README in the browser, even tho I ran it with these flags:
FlexASIO-1.7a.exe /VERYSILENT /SUPPRESSMSGBOXES /NORESTART
I didn't have any luck with /SAVEINF either.
So perhaps the only way would be to add a flag to uncheck Open README, unless there's a method I'm missing.

@dechamps dechamps added the bug label Jun 3, 2021
@dechamps
Copy link
Owner

dechamps commented Jun 3, 2021

Mmm, yeah I can see how that could be a problem.

Feel free to send a pull request if you can figure out the correct Inno Setup config to fix it. Otherwise I'll take a look at it when I find the time to do some FlexASIO work.

@ThreeDeeJay
Copy link
Contributor Author

ThreeDeeJay commented Aug 25, 2021

I found what seems to be a one-liner fix here: https://jrsoftware.org/ishelp/index.php?topic=runsection

skipifsilent
Valid only in a [Run] section. Instructs Setup to skip this entry if Setup is running (very) silent.

However, I wasn't able to test myself since I've been having a hard time building so hopefully you can get a chance and test it and make sure it actually works before merging #130
🤞

@dechamps dechamps added this to the FlexASIO 1.8 milestone Oct 3, 2021
@dechamps
Copy link
Owner

This is fixed in FlexASIO 1.8.

@ThreeDeeJay
Copy link
Contributor Author

Confirmed working on my end 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants