Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoCoSegmentationDataSet._generate_samples_and_targets() doesn't call super (= no caching) #351

Closed
michaelitvin opened this issue Sep 6, 2022 · 3 comments
Closed

CoCoSegmentationDataSet._generate_samples_and_targets() doesn't call super (= no caching) #351

michaelitvin opened this issue Sep 6, 2022 · 3 comments
Assignees
@shaydeci
Labels
🐛 Bug Something isn't working

Comments

@michaelitvin
Copy link

Describe the bug

CoCoSegmentationDataSet._generate_samples_and_targets() doesn't call the corresponding parent class method, and therefore image and label caching is doesn't work for this class.
The solution is to add super()._generate_samples_and_targets() as the last line in CoCoSegmentationDataSet._generate_samples_and_targets().
Excuse me for not making this as a pull request this time.
@dagshub
Copy link

dagshub bot commented Sep 6, 2022

Join the discussion on DagsHub!

@oferbaratz oferbaratz added the 🐛 Bug Something isn't working label Sep 6, 2022
@shaydeci
Copy link
Collaborator

shaydeci commented Sep 6, 2022 •
edited
Loading

@michaelitvin I will merge a fix and release a version soon, thanks !

@shaydeci shaydeci mentioned this issue Sep 6, 2022
Merged
@shaydeci
Copy link
Collaborator

Fixed in latest release (3.0.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaydeci shaydeci

Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelitvin @shaydeci @oferbaratz