Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome Map broken with latest commits #205

Open
arusa opened this issue Jan 30, 2023 · 6 comments
Open

Awesome Map broken with latest commits #205

arusa opened this issue Jan 30, 2023 · 6 comments

Comments

@arusa
Copy link
Contributor

arusa commented Jan 30, 2023

Since the commits, that make the module compatible to Decidim 0.27, the "Awesome Map" is broken. It only shows the whole world map (fully zoomed out) and the browser console shows a JS error.

image

image

After reverting our Gemfile back to my last commit the map is zoomed in again:

image

But I realized, that the browser console also displays some errors with this version:

image

I am running Decidim 0.27.0 and decidim_awesome on commit 0812def

I tested it using:

  • OS: MacOS 13.2
  • Browser Safari 16.3
@microstudi
Copy link
Contributor

is this a production server? or a development instance?

@arusa
Copy link
Contributor Author

arusa commented Jan 31, 2023

It's on a staging instance of a new platform that hasn't been released to production yet.

@microstudi
Copy link
Contributor

So far, I'm been unable to replicate this. Could it be that you have to remove the public/decidim-packs folder and run assets:precompile again?
I did found some issues with the awesome map, but they weren't the ones you are reporting. #206

@arusa
Copy link
Contributor Author

arusa commented Feb 19, 2023

Thanks for your update. I deploy using git push to dokku (herokuish) and public/decidim-packs is in .gitignore. So it gets rebuilt on every deploy.

I'll try it again with the latest updates and see if the errors still happen and if I can fix them.

@arusa
Copy link
Contributor Author

arusa commented Feb 19, 2023

I tried to test the latest decidim_awesome updates, but assets:precompile fails because src/decidim/editor/clipboard_override doesn't exist in decidim 0.27.0, but only starting in 0.27.1

clipboard_override is referenced in app/packs/src/decidim/decidim_awesome/editors/editor.js)

I have to check if some bugs were already fixed in 0.27.1 or 0.27.2 before updating...

@microstudi
Copy link
Contributor

thanks, not sure if it is worth it to make it work with 27.0 though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants