Fix broken conference registering when no registration types #12706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarbaraOliveira13
changed the title
…1221) * fix: hide register button in conference when no registration types * lint: add missing space in conference show view page
andreslucena
added
type: bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andreslucena
requested changes
Apr 23, 2024
There was a problem hiding this comment.
@BarbaraOliveira13 @Stef-Rousset great fix and welcome to Decidim!
I could find an edge case although: what happens when the registration type is not published? As far as I could see, we're showing a buggy behavior: showing the Register button but then the RoutingError in the page. I think this could be fixed with the following snippet:
diff --git a/decidim-conferences/app/models/decidim/conference.rb b/decidim-conferences/app/models/decidim/conference.rb
index 1133c5c18d..936ceefa72 100644
--- a/decidim-conferences/app/models/decidim/conference.rb
+++ b/decidim-conferences/app/models/decidim/conference.rb
@@ -113,6 +113,12 @@ module Decidim
available_slots > conference_registrations.count
end
+ def has_published_registration_types?
+ return false if registration_types.empty?
+
+ registration_types.any?(&:published_at?)
+ end
+
def remaining_slots
available_slots - conference_registrations.count
end
diff --git a/decidim-conferences/app/views/decidim/conferences/conferences/_conference_hero.html.erb b/decidim-conferences/app/views/decidim/conferences/conferences/_conference_hero.html.erb
index b2e617f920..a974d508e2 100644
--- a/decidim-conferences/app/views/decidim/conferences/conferences/_conference_hero.html.erb
+++ b/decidim-conferences/app/views/decidim/conferences/conferences/_conference_hero.html.erb
@@ -19,7 +19,7 @@
<% if current_participatory_space.registrations_enabled? %>
<% if current_participatory_space.has_registration_for?(current_user) %>
<%= link_to t("layouts.decidim.conference_hero.manage_registration"), decidim_conferences.conference_registration_types_path(current_participatory_space), class: "button button__lg button__primary" %>
- <% elsif current_participatory_space.registration_types.present? %>
+ <% elsif current_participatory_space.has_published_registration_types? %>
<%= link_to t("layouts.decidim.conference_hero.register"), decidim_conferences.conference_registration_types_path(current_participatory_space), class: "button button__lg button__secondary" %>
<% end %>
<% end %>You'd need to implement it in the other places where we're using the present? and make some specs too. Can you apply this or other solution to the bug that
|
Hello @andreslucena, thank you for your welcome and for the comment ! We are going to update the code and apply your suggestions, and add tests of course. |
Conference registering change requests
|
Hello @andreslucena , we have applied your recommandations, thx again ! |
andreslucena
requested changes
Apr 25, 2024
decidim-conferences/spec/system/conference_registrations_spec.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/spec/system/conference_registrations_spec.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/spec/system/conference_registrations_spec.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/spec/system/conference_registrations_spec.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/spec/system/conference_registrations_spec.rb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix conferences registers when the registration types are empty and registration is enabled
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
co-writter: @Stef-Rousset