-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in the assignment of evaluators #12994
Conversation
...roposals/app/views/decidim/proposals/admin/proposals/bulk_actions/_valuators_picker.html.erb
Fixed
Show fixed
Hide fixed
This reverts commit da11fc3.
Hey @mllocs, please ping me again when this is ready to review |
@NilHomedes Yep, we were having issues with the staging server and we couldn't deploy updates. Now staging is up to date and valuators shouldn't see the "unassign" action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the job, looks awesome @mllocs 🚀
@andreslucena pinging just in case the notification got lost ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked out the feature and the code and apart from some bugs related to bulk actions (that are out of the scope of the current PR and I'll handle one this is merged), I only have two suggestions. Can you check them out so we can merge this? Thanks
decidim-proposals/spec/system/admin/admin_manages_proposal_valuators_spec.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I didn't explain right what I mean with the literal change, can you check it out please?
🎩 What? Why?
📌 Related Issues
Fixes #12903
Testing
📷 Screenshots