Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in the assignment of evaluators #12994

Merged
merged 20 commits into from
Jun 28, 2024

Conversation

mllocs
Copy link
Contributor

@mllocs mllocs commented Jun 12, 2024

🎩 What? Why?

  • Allow selecting multiple valuators when assigning valuators to proposals in bulk.
  • Allow evaluators to assign other evaluators.

📌 Related Issues

Fixes #12903

Testing

📷 Screenshots

Screenshot 2024-06-12 at 13 12 35

♥️ Thank you!

@probot-autolabeler probot-autolabeler bot added javascript Pull requests that update Javascript code module: admin module: proposals labels Jun 12, 2024
github-actions[bot]

This comment was marked as resolved.

@mllocs mllocs self-assigned this Jun 12, 2024
@mllocs mllocs added the type: feature PRs or issues that implement a new feature label Jun 12, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 12, 2024
@mllocs mllocs added the contract: 2024-developments Barcelona City Council contract label Jun 12, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 12, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 13, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 13, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 13, 2024
@mllocs mllocs marked this pull request as ready for review June 13, 2024 11:50
@furilo furilo self-requested a review June 14, 2024 05:56
github-actions[bot]
github-actions bot previously approved these changes Jun 21, 2024
github-actions[bot]
github-actions bot previously approved these changes Jun 21, 2024
@NilHomedes
Copy link
Member

Hey @mllocs, please ping me again when this is ready to review

@mllocs
Copy link
Contributor Author

mllocs commented Jun 21, 2024

Hey @mllocs, please ping me again when this is ready to review

@NilHomedes Yep, we were having issues with the staging server and we couldn't deploy updates.

Now staging is up to date and valuators shouldn't see the "unassign" action.

NilHomedes
NilHomedes previously approved these changes Jun 21, 2024
Copy link
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the job, looks awesome @mllocs 🚀

@NilHomedes NilHomedes requested review from andreslucena and removed request for andreslucena June 21, 2024 15:38
@NilHomedes NilHomedes removed their assignment Jun 21, 2024
@mllocs
Copy link
Contributor Author

mllocs commented Jun 25, 2024

@andreslucena pinging just in case the notification got lost ;)

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked out the feature and the code and apart from some bugs related to bulk actions (that are out of the scope of the current PR and I'll handle one this is merged), I only have two suggestions. Can you check them out so we can merge this? Thanks

decidim-proposals/config/locales/en.yml Outdated Show resolved Hide resolved
@mllocs mllocs dismissed stale reviews from NilHomedes and github-actions via 0780d99 June 27, 2024 08:29
@mllocs mllocs requested a review from andreslucena June 27, 2024 08:29
github-actions[bot]
github-actions bot previously approved these changes Jun 27, 2024
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I didn't explain right what I mean with the literal change, can you check it out please?

@mllocs mllocs requested a review from andreslucena June 27, 2024 11:43
@andreslucena andreslucena merged commit e9f82c7 into develop Jun 28, 2024
84 checks passed
@andreslucena andreslucena deleted the feat/improving-assignment-evaluators branch June 28, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract: 2024-developments Barcelona City Council contract javascript Pull requests that update Javascript code module: admin module: proposals type: feature PRs or issues that implement a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements in the assignment of evaluators
5 participants