Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The date of the proposals does not appear on the XL card #3040

Closed
Xfolchf opened this issue Mar 19, 2018 · 7 comments
Closed

The date of the proposals does not appear on the XL card #3040

Xfolchf opened this issue Mar 19, 2018 · 7 comments
Assignees
Labels
module: proposals type: bug Issues that describe a bug

Comments

@Xfolchf
Copy link

Xfolchf commented Mar 19, 2018

This is a (Bug Report / Feature Proposal)

馃帺 Description

For bug reports:

  • What went wrong?
    The date of the proposals is only visible from the proposal browser, on the "M" size cards. When you click on the proposal the date does not appear.
    This bug can be seen on this same card.

https://meta.decidim.barcelona/processes/bug-report/f/210/proposals/12338

馃搵 Additional Data

  • Decidim deployment where you found the issue:
  • Browser & version:
  • Screenshot:
  • Error messages:
  • URL to reproduce the error:
@xabier
Copy link
Contributor

xabier commented Apr 16, 2018

@rbngzlv can we have this for 0.10.1 or 0.11?

@rbngzlv
Copy link
Contributor

rbngzlv commented Apr 17, 2018

Hi @xabier, I never worked on the proposals component, it is improved by mods-b, although I'm not sure if they touched this part of proposals.

@agustibr and @tramuntanal can you comment on this?

@tramuntanal
Copy link
Contributor

It seems that @josepjaume made it disappear in this commit: e2b60ab#diff-45c5b1499ee5281d1ce650a33758a1acL16

Related with this PR: #1422

(Thanks @rbngzlv for the investigation)

@mrcasals
Copy link
Contributor

@tramuntanal @rbngzlv nope, that PR moved the date to the decidim-proposals/app/views/decidim/proposals/proposals/_author.html.erb file.

@rbngzlv
Copy link
Contributor

rbngzlv commented Apr 17, 2018

I think that I'm wrong, the commit I mentioned has moved it to a partial (is the last line, and I have overlooked). Give me a moment, please.

@rbngzlv
Copy link
Contributor

rbngzlv commented Apr 17, 2018

Yes @mrcasals, you are right. You are faster than me writing xD

@ghost ghost assigned rbngzlv Apr 18, 2018
@ghost ghost added the status: WIP label Apr 18, 2018
@rbngzlv
Copy link
Contributor

rbngzlv commented Apr 18, 2018

Ok, I think it was disappeared when the unique nicknames were introduced: 2e2931a#diff-4385024b52d43f495ab1c0114e1d4d23L21.

Anyway we have done a PR to restore it.

@ghost ghost removed the status: WIP label Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: proposals type: bug Issues that describe a bug
Projects
None yet
Development

No branches or pull requests

6 participants