Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error layout services for meetings #4118

Closed
Xfolchf opened this issue Sep 14, 2018 · 6 comments
Closed

Error layout services for meetings #4118

Xfolchf opened this issue Sep 14, 2018 · 6 comments
Assignees
Labels
module: meetings type: bug Issues that describe a bug

Comments

@Xfolchf
Copy link

Xfolchf commented Sep 14, 2018

Describe the bug
There is a layout error in the space where the description of the services of a meeting is shown. If the descriptive text is very long, there is a part that is not displayed.

https://meta.decidim.org/processes/bug-report/f/210/proposals/13131

Screenshots
If applicable, add screenshots to help explain your problem.
image

@Xfolchf Xfolchf added the type: bug Issues that describe a bug label Sep 14, 2018
@mrcasals
Copy link
Contributor

mrcasals commented Dec 7, 2018

This happens when a long word overflows the box. In the screenshot, the email overflows it.

@Crashillo can you check this please?

@Crashillo Crashillo self-assigned this Dec 12, 2018
@Crashillo
Copy link
Member

Crashillo commented Dec 12, 2018

I'm checking here, appending text to the sidebar and it seems it was already fixed.

Anyway, would it be possible when people report bugs to include the url where the error was found? As the same as they provide screenshots.

@mrcasals
Copy link
Contributor

@Crashillo I can still reproduce it in the URL you point to using this HTML:

              <div>
                <h5 class="card--list__heading heading-small">Traducció simultània</h5>
                <span class="text-medium">No n'hi haurà però provem khfbdfbdfjbdfjbfdjfjbfbjfdbdfbdfbfdbdffdjdfjdf com kshgf skyfg skrgf skyfs kdyfghs dfhg sldufh ses visualitza un servei</span>
              </div>

@Crashillo
Copy link
Member

That's because you've used a very long word. That's quite uncommon. The solution to this, would be adding the CSS property hyphens: auto to the span, but it will cause other words to be splitted as well. And this behaviour is not handle in some other texts throughout Decidim.

Look how it looks a long text:
imagen

@mrcasals
Copy link
Contributor

@Crashillo the reported issue was caused because someone added an email address in that field, which caused the layout to break. If you think this is not a bug, then we can close it.

@ghost ghost added the status: WIP label Dec 12, 2018
@Crashillo
Copy link
Member

At the end, I was hooked on this. Take a look at #4664.

By the way, I noticed both integrated and design markups are slightly different. Mostly, missing classes. You may check out the code at https://decidim-design.herokuapp.com/public/meetings/meeting-view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: meetings type: bug Issues that describe a bug
Projects
None yet
Development

No branches or pull requests

3 participants