Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemblies filter doesn't work properly #4772

Closed
carolromero opened this issue Jan 14, 2019 · 5 comments
Closed

Assemblies filter doesn't work properly #4772

carolromero opened this issue Jan 14, 2019 · 5 comments
Assignees
Labels
type: bug Issues that describe a bug

Comments

@carolromero
Copy link
Member

Describe the bug
The functionality of filtering Assemblies by type has been incorporated. However, when you select an assembly type it does not appear as selected and there is no indicator to show that the filter is being applied.

To reproduce go to https://meta.decidim.org/assemblies?filter=working_group

Additional context
https://meta.decidim.org/processes/bug-report/f/210/proposals/13776

@carolromero carolromero added the type: bug Issues that describe a bug label Jan 14, 2019
@aitorlb
Copy link
Contributor

aitorlb commented Jan 17, 2019

Hi @carolromero , take a look at the PR that I've opened.

@aitorlb aitorlb self-assigned this Jan 17, 2019
@ghost ghost added the status: WIP label Jan 17, 2019
@carolromero
Copy link
Member Author

Hi @aitorlb looks ok to me! Besides showing the selected filter, have you incorporated an spinner or some indicator while the filter is being applied?

@aitorlb
Copy link
Contributor

aitorlb commented Jan 18, 2019

@carolromero I did not incorporate an indicator while the filter is being applied, but I think that with the new behaviour it will not be necessary. I propose you make that decision after experiencing the new version. Sounds ok?

@carolromero
Copy link
Member Author

@aitorlb sounds good! thanks

@aitorlb
Copy link
Contributor

aitorlb commented Jan 21, 2019

@carolromero I added a gif to the PR

@ghost ghost removed the status: WIP label Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues that describe a bug
Projects
None yet
Development

No branches or pull requests

3 participants