Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To be able to get the URL of a comment #5609

Closed
4 tasks done
andreslucena opened this issue Jan 8, 2020 · 3 comments · Fixed by #5662
Closed
4 tasks done

To be able to get the URL of a comment #5609

andreslucena opened this issue Jan 8, 2020 · 3 comments · Fixed by #5662
Labels
contract: PAM2020 Barcelona City Council contract
Projects

Comments

@andreslucena
Copy link
Member

andreslucena commented Jan 8, 2020

ref: PP024-3

User story

Is your feature request related to a problem? Please describe.

As a visitor sometimes I want to link to another comment.

Describe the solution you'd like

To have a unique URL to see a comment thread as other platforms that have comments threading has. It should be really clear that there other comments on this Proposal.

Describe alternatives you've considered

To link to a comment on the same page of the Proposal/Debate/etc, as Discourse does. On our case for perfomance reasons could be really difficult to achieve, specially what happens if a proposal has thousands of comments? Discourse has summary views for these threads.

Additional context

Examples on:

It's really important to be clear that there are more comments on this page (for instance on Meneame is not clear that this is happening)

Acceptance criteria

  • As a visitor I can get the URL of a given comment
  • As a visitor I can go to the URL of a given comment and see this comment
  • As a visitor when I go to the URL of a given comment I can see that there's more comments: "You're only viewing a comment thread. See all comments"
  • As a visitor when I go to the URL of a given comment I go to a page with this only this comment

Related issues

@andreslucena andreslucena created this issue from a note in PAM2020 (Sprint Backlog) Jan 8, 2020
@Jordi-Miro Jordi-Miro added the contract: PAM2020 Barcelona City Council contract label Jan 9, 2020
@andreslucena andreslucena added this to the Release for PAM v1 milestone Jan 13, 2020
@mrcasals mrcasals moved this from Sprint Backlog to Doing in PAM2020 Jan 24, 2020
@mrcasals
Copy link
Contributor

@decidim/product this is now live in staging for you to review!

I set up some comments here so you can test the feature:

http://staging.decidim.codegram.com/processes/nihil-dolor/f/3/proposals/7

@mrcasals mrcasals moved this from Doing to Testing in PAM2020 Jan 27, 2020
@mrcasals
Copy link
Contributor

@decidim/product I've updated the code to scroll to the comments section when checking a single comment, can you review it?

@carolromero
Copy link
Member

yep, I think we got it now. Thanks!

@carolromero carolromero moved this from Testing to Technical Review in PAM2020 Jan 27, 2020
@mrcasals mrcasals moved this from Technical Review to Done in PAM2020 Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract: PAM2020 Barcelona City Council contract
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants