Logining-in should not bring you to home page

[xabier]

This is a Bug Report

🎩 Description

For bug reports:

• What went wrong?

When you are navigating on Decidim and suddenly you are prompted to sign-in, once you do it Decidim redirect you to the home page.

• What did you expect should have happened?

I expect to remain on the same page where I was asked to sign-in

• What was the config you used?

This bug is not config specific, it applies (to my knowledge) to all decidims.

[xabier]

@josepjaume @mrcasals please check this out.

[josepjaume]

I actually worked a bit in this direction. Please label and prioritize accordingly 👍

[josepjaume]

To add more context: keeping the user on the same page is not always the desired solution. Imagine we are searching the proposal list, we try to vote a proposal, and then we're prompted to log in. We probably want the user to come back to the proposal she tried to vote, instead of the list (we would have lost context). Same applies to other situations like creating a new proposal, etc.

[xabier]

To add more context: keeping the user on the same page is not always the desired solution. Imagine we are searching the proposal list, we try to vote a proposal, and then we're prompted to log in. We probably want the user to come back to the proposal she tried to vote, instead of the list (we would have lost context). Same applies to other situations like creating a new proposal, etc.

I understand the cases where you want users to be redirected somewhere else other than the page where they were located when prompted to login, nice point. But these are very rare cases, in the case of the proposal this would only happen if the page is random and when returning to the "same" page, well it is actually not the same 😄

In any case, I think it is much better that the default behaviour brings you to the page where you where. Seriously. I use decidim quite a lot, I don't use cookies (this is a personal security choice) and whenever I am directed to decidim via a link (shared on telegram, mail or otherwise) and I need to perform an action... I have to re-start, is very annoying.

Let's try to bring the user to the page she was originaly when prompted to login and then we can improve from there.

[josepjaume]

Definitely! But we can do both :). It's not a difficult task, just needs to be solved right.

[xabier]

Sure, but should not leave issues behind trying to find a perfect solution if an optimal good-enough solution is a low-hanging-fruit

[josepjaume]

It's a matter of finding the balance. Sometimes a collection of low-cost, short-term solution can cause a long-term mess :). Anyway, I think I know how to proceed, I'm totally aware of the issue!

…

On Dec 9, 2017 14:46, "Xabier E. Barandiaran" ***@***.***> wrote: Sure, but should not leave issues behind trying to find a perfect solution if an optimal good-enough solution is a low-hanging-fruit — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2321 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG0gt8ToZAmejEf2xT6h-UbGpmdebCDks5s-o8xgaJpZM4Q0w_9> .

[xabier]

Nice!

[josepjaume]

@oriolgual two things to consider:

There's two scenarios where we can redirect the user outside of their current page and we'd like them to return to the same place.

1. We ask them to log in.
2. We need them to validate against some authorization, either because that authorization doesn't exist yet, it's expired, or we need more data.

It's not always gonna be easy to return the user to the same page (how to return to the same position in a list?) - I suggest using a session cookie to store the page where we want the user to be redirected after the login flow (via a get parameter like redirect_url).

Devise suggests a similar approach and we had it working in the past, but it got removed in #1966 because it wasn't working properly.

This can be quite complex but it has an enormous impact on the user flow.

[deivid-rodriguez]

Also, there's some related discussion here, in case it may help.