-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google OAuth button not compatible with Google branding guidelines #4630
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @xabier feel free to chime in. |
This is an issue that prevents any Decidim application out there to pass the manual reviews of Facebook and Google. |
Hi @ahukkanen thanks for reporting and documenting this! Do you think you could do a PR to make the changes to adapt to the guidelines? |
@carolromero We unfortunately don't currently have any client willing to cover the development cost of that. They either have their own self-managed authentication system or don't care about this. You actually only need to pass the manual review in case you want to get access to more user information through these APIs. The basic authentication will still work regardless of passing the review process. Anyways, I think that as a platform, Decidim would benefit from complying with the 3rd party guidelines. The following would support that:
A direct quote from Google Sign-In Branding Guidelines:
A direct quote from Facebook Asset and Brand Guidelines:
|
@decidim/lot-px can you check this? |
Describe the bug
We submitted one Decidim instance to the Google OAuth review process and it bounced back because the Google sign in button incorporated in Decidim does not meet Google's branding guidelines.
The branding guides are available for reading here:
https://developers.google.com/identity/branding-guidelines
The main issue is the displayed logo, the button itself I believe can pass easily if the color is changed accordingly to the guidelines. See for example Pinterest sign in page for proper branding:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
We would expect the design to be compatible with Google's branding guidelines.
Screenshots
Stacktrace
This is a design bug, no stacktrace involved.
Extra data (please complete the following information):
Additional context
It may be wise to also check the branding of the other services at the same time.
For Facebook, here is info about the Facebook button design:
https://developers.facebook.com/docs/facebook-login/userexperience/
Twitter doesn't provide any clear guidance regarding the button, they just ask to follow their branding guidelines which are available here:
https://about.twitter.com/en_us/company/brand-resources.html
The text was updated successfully, but these errors were encountered: