Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar-check readme, fix file names and imports in all files #20

Merged
merged 10 commits into from Apr 24, 2021

Conversation

nab170130
Copy link
Contributor

Grammar-checked the readme file. Fixed the file names so that all are lowercase, matching convention. Fixed imports in ALL files. Removed import block in init.py file in active_learning_strategies and fixed imports in all relevant files. Each file was tested: All attempted imports worked, and every example / testing script and notebook worked.

Note: THE GOOGLE COLAB NOTEBOOKS THAT ARE LINKED IN THE README NEED TO HAVE THE CHANGES IN THE IMPORT STATEMENTS PRESENT IN THE NOTEBOOKS FOLDER. MAKE SURE TO INCORPORATE THOSE CHANGES WHEN MERGING.

nab170130 and others added 10 commits April 22, 2021 19:21
Enforced lowercase on all module names; removed import list in distil/active_learning_strategies/__init__.py
Fixed any grammar issues that were detected
Trimmed more imports and fixed strategy imports in test scripts and example notebooks.
Changed git configuration file to not ignore filename case
Changed "ramdom" to "random" in lost of algorithms
Removed extra space in notebook name
Fixed imports in notebooks
Added extra distil. to alleviate notebook imports
@ApurvaDani ApurvaDani merged commit 5ae07a3 into main Apr 24, 2021
@nab170130 nab170130 deleted the name_readme branch April 24, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants