do not fail if no devices are present #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If absolutely no devices are available when setting up the recorder the setup no longer fails but instead just doesn't try to set up the required streams and devices. Most of our previous code already handled these situations but it never came up during setup that no device was available.
We tested this on a MacMini of a colleague that had no microphone and no camera available. Recording setup completed and a video recording was possible - just without external sound or the camera-video-panel available.
If you press V to show the camera panel if no stream is available the program also doesn't fail or abort the recording and instead shows a small informational message and continues to record.
As this situation never came up before and there seems to be no way to emulate this hardware configuration I would suggest you review this in the form of "on my device the behavior did not change".