Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

highlight code fails when main language loads before required languages #1387

Closed
1 task done
peterpeterparker opened this issue Nov 12, 2021 · 0 comments · Fixed by #1388
Closed
1 task done

highlight code fails when main language loads before required languages #1387

peterpeterparker opened this issue Nov 12, 2021 · 0 comments · Fixed by #1388
Labels
bug Something isn't working highlight-code Highlight code web component

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Nov 12, 2021 •
edited

Affected part of DeckDeckGo

  • Web Components

Reproduction

Steps to reproduce:

  1. highlight code with tsx defined as lang

Expected Behavior

No loading errors.

Actual Behavior

The component fails time to time when loading the main language (tsx) is faster than its required languages (typescript and jsx).

It seems that the required should be loaded first and, only when finished, then the main scripts should be loaded.

Screenshot

Capture d’écran 2021-11-12 à 14 47 23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working highlight-code Highlight code web component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: higlight code sort required languages scripts first deckgo/deckdeckgo
1 participant
@peterpeterparker