Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

youtube: smoother display transition #570

Closed
peterpeterparker opened this issue Jan 9, 2020 · 0 comments · Fixed by #683
Closed

youtube: smoother display transition #570

peterpeterparker opened this issue Jan 9, 2020 · 0 comments · Fixed by #683
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.0.0

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Jan 9, 2020 •
edited

Affected part of DeckDeckGo

  • [X ] Web Components

Feature Description

Our @deckdeckgo/youtube takes care of rendering a YouTube iframe using their API but, right now, it's a bit "either nothing, either everything" respectively there isn't any smooth transition between these two states.

The idea is the following: loading the iframe but per default with no visibility and then, when loaded, to smoothly apply a transition until visible.

We implemented kind of the same concept in our lazy-img (for images) component already.

Use Case

Links for the component:
@peterpeterparker peterpeterparker added enhancement New feature or request good first issue Good for newcomers labels Jan 9, 2020
@peterpeterparker peterpeterparker changed the title YouTube: smoother display transition youtube: smoother display transition Jan 9, 2020
@boradakash boradakash mentioned this issue Apr 4, 2020
Merged
7 tasks
@peterpeterparker peterpeterparker linked a pull request Apr 4, 2020 that will close this issue
youtube: smoother display transition #683
Merged
7 tasks
@peterpeterparker peterpeterparker added this to the studio-v1.0.0 milestone Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

youtube: smoother display transition boradakash/deckdeckgo
1 participant
@peterpeterparker