-
Notifications
You must be signed in to change notification settings - Fork 108
/
pdb.go
242 lines (200 loc) · 6.57 KB
/
pdb.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
/*
Copyright 2021 Flant JSC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package resources
import (
"fmt"
appsv1 "k8s.io/api/apps/v1"
policyv1 "k8s.io/api/policy/v1"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/runtime"
"github.com/deckhouse/deckhouse/testing/matrix/linter/rules"
"github.com/deckhouse/deckhouse/testing/matrix/linter/rules/errors"
"github.com/deckhouse/deckhouse/testing/matrix/linter/storage"
)
type nsLabelSelector struct {
namespace string
selector labels.Selector
}
func (s *nsLabelSelector) Matches(namespace string, labelSet labels.Set) bool {
return s.namespace == namespace && s.selector.Matches(labelSet)
}
// ControllerMustHavePDB adds linting errors if there are pods from controllers which are not covered (except DaemonSets)
// by a PodDisruptionBudget
func ControllerMustHavePDB(linter *rules.ObjectLinter) {
scope := newLintingScope(linter.ObjectStore, linter.ErrorsList)
pdbSelectors, lerr := collectPDBSelectors(scope)
if !lerr.IsEmpty() {
linter.ErrorsList.Add(lerr)
return
}
for _, object := range scope.Objects() {
if !isPodController(object.Unstructured.GetKind()) {
continue
}
if isPodControllerDaemonSet(object.Unstructured.GetKind()) {
continue
}
lerr := ensurePDBIsPresent(pdbSelectors, object)
linter.ErrorsList.Add(lerr)
}
}
// DaemonSetMustNotHavePDB adds linting errors if there are pods from DaemonSets which are covered
// by a PodDisruptionBudget
func DaemonSetMustNotHavePDB(linter *rules.ObjectLinter) {
scope := newLintingScope(linter.ObjectStore, linter.ErrorsList)
pdbSelectors, lerr := collectPDBSelectors(scope)
if !lerr.IsEmpty() {
linter.ErrorsList.Add(lerr)
return
}
for _, object := range scope.Objects() {
if !isPodController(object.Unstructured.GetKind()) {
continue
}
if !isPodControllerDaemonSet(object.Unstructured.GetKind()) {
continue
}
lerr := ensurePDBIsNotPresent(pdbSelectors, object)
linter.ErrorsList.Add(lerr)
}
}
// collectPDBSelectors collects selectors for matching pods
func collectPDBSelectors(scope *lintingScope) ([]nsLabelSelector, errors.LintRuleError) {
selectors := make([]nsLabelSelector, 0)
for _, object := range scope.Objects() {
if object.Unstructured.GetKind() != "PodDisruptionBudget" {
continue
}
labelSelector, lerr := parsePDBSelector(object)
if !lerr.IsEmpty() {
return nil, lerr
}
sel := nsLabelSelector{
namespace: object.Unstructured.GetNamespace(),
selector: labelSelector,
}
selectors = append(selectors, sel)
}
return selectors, errors.EmptyRuleError
}
// ensurePDBIsPresent returns true if there is a PDB controlling pods from the pod contoller
// VPA is assumed to be present, since the PDB check goes after VPA check.
func ensurePDBIsPresent(selectors []nsLabelSelector, podController storage.StoreObject) errors.LintRuleError {
podLabels, err := parsePodControllerLabels(podController)
if err != nil {
return errors.NewLintRuleError(
"PDB004",
podController.Identity(),
err,
"Cannot parse pod controller")
}
podNamespace := podController.Unstructured.GetNamespace()
podLabelsSet := labels.Set(podLabels)
for _, sel := range selectors {
if sel.Matches(podNamespace, podLabelsSet) {
return errors.EmptyRuleError
}
}
return errors.NewLintRuleError(
"PDB001",
podController.Identity(),
podLabelsSet,
"No PodDisruptionBudget matches pod labels of controller")
}
// ensurePDBIsNotPresent returns true if there is not a PDB controlling pods from the pod contoller
// VPA is assumed to be present, since the PDB check goes after VPA check.
func ensurePDBIsNotPresent(selectors []nsLabelSelector, podController storage.StoreObject) errors.LintRuleError {
podLabels, err := parsePodControllerLabels(podController)
if err != nil {
return errors.NewLintRuleError(
"PDB004",
podController.Identity(),
err,
"Cannot parse pod controller")
}
podNamespace := podController.Unstructured.GetNamespace()
podLabelsSet := labels.Set(podLabels)
for _, sel := range selectors {
if sel.Matches(podNamespace, podLabelsSet) {
return errors.NewLintRuleError(
"PDB002",
podController.Identity(),
podLabelsSet,
"PodDisruptionBudget matches pod labels of controller")
}
}
return errors.EmptyRuleError
}
func parsePDBSelector(pdbObj storage.StoreObject) (labels.Selector, errors.LintRuleError) {
content := pdbObj.Unstructured.UnstructuredContent()
converter := runtime.DefaultUnstructuredConverter
pdb := &policyv1.PodDisruptionBudget{}
err := converter.FromUnstructured(content, pdb)
if err != nil {
lerr := errors.NewLintRuleError(
"PDB002",
pdbObj.Identity(),
err,
"Cannot parse PodDisruptionBudget")
return nil, lerr
}
sel, err := v1.LabelSelectorAsSelector(pdb.Spec.Selector)
if err != nil {
lerr := errors.NewLintRuleError(
"PDB003",
pdbObj.Identity(),
err,
"Cannot parse label selector")
return nil, lerr
}
if len(pdb.Annotations["helm.sh/hook"]) > 0 || len(pdb.Annotations["helm.sh/hook-delete-policy"]) > 0 {
lerr := errors.NewLintRuleError(
"PDB005",
pdbObj.Identity(),
err,
"PDB must have no helm hook annotations")
return nil, lerr
}
return sel, errors.EmptyRuleError
}
func parsePodControllerLabels(object storage.StoreObject) (map[string]string, error) {
content := object.Unstructured.UnstructuredContent()
converter := runtime.DefaultUnstructuredConverter
kind := object.Unstructured.GetKind()
switch kind {
case "Deployment":
deployment := new(appsv1.Deployment)
err := converter.FromUnstructured(content, deployment)
if err != nil {
return nil, err
}
return deployment.Spec.Template.Labels, nil
case "DaemonSet":
daemonSet := new(appsv1.DaemonSet)
err := converter.FromUnstructured(content, daemonSet)
if err != nil {
return nil, err
}
return daemonSet.Spec.Template.Labels, nil
case "StatefulSet":
statefulSet := new(appsv1.StatefulSet)
err := converter.FromUnstructured(content, statefulSet)
if err != nil {
return nil, err
}
return statefulSet.Spec.Template.Labels, nil
default:
return nil, fmt.Errorf("object of kind %s is not a pod controller", kind)
}
}