Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decimal separator associated with selected number format #44

Closed
mathoudebine opened this issue Jul 1, 2022 · 7 comments · Fixed by #45
Closed

Use decimal separator associated with selected number format #44

mathoudebine opened this issue Jul 1, 2022 · 7 comments · Fixed by #45
Labels
bug Something isn't working

Comments

@mathoudebine
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The temperatures are always displayed using a period/dot for the decimal separator.
temperatures_period

Describe the solution you'd like
The temperatures would be better displayed using the decimal separator associated with selected language (for example: can be a comma https://en.wikipedia.org/wiki/Decimal_separator#Usage_worldwide).
temperatures_comma

@decompil3d decompil3d added the bug Something isn't working label Jul 1, 2022
@mathoudebine mathoudebine changed the title Use decimal separator associated with selected language Use decimal separator associated with selected number format Jul 1, 2022
@decompil3d
Copy link
Owner

You're right -- I think it just needs a call to the number format utility in custom-card-helpers.

@mathoudebine
Copy link
Contributor Author

Yes, I just found out that there is a "Number format" setting on the profile page:

number_format

I think this setting should be used for number display

@decompil3d
Copy link
Owner

Can you try 2.3.3-beta.0 and let me know if it works for you?

@mathoudebine
Copy link
Contributor Author

mathoudebine commented Jul 1, 2022

Unfortunately it does not work with 2.3.3-beta.0, temperatures are still displayed with period as a separator no matter which number format or language I choose ☹️

@decompil3d
Copy link
Owner

Oops, I made the release wrong. Try 2.3.3-beta.1

@mathoudebine
Copy link
Contributor Author

Works like a charm! Thanks for your work 🚀
beta-version

@decompil3d
Copy link
Owner

Released in 2.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants