Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RtYamlLine.java:39-43: Method indentation() also checks that th... #55

Closed
0pdd opened this issue Feb 13, 2017 · 4 comments
Closed

RtYamlLine.java:39-43: Method indentation() also checks that th... #55

0pdd opened this issue Feb 13, 2017 · 4 comments

Comments

@0pdd
Copy link

0pdd commented Feb 13, 2017

The puzzle 52-1a414e89 in src/main/java/com/amihaiemil/camel/RtYamlLine.java (lines 39-43) has to be resolved: Method indentation() also checks that the value is multiple of 2. We should extract this in a decorator called WellIndentedLine which will also check if the intendetaion is correct relative to the previous line. It would be used like this:
YamlLine line = new WellINdentedLine(line, previousLine).

The puzzle was created by amihaiemil on 13-Feb-17.

Estimate: 30 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@0pdd
Copy link
Author

0pdd commented Feb 13, 2017

@amihaiemil please pay attention to this new issue.

@amihaiemil
Copy link
Member

amihaiemil commented Feb 13, 2017

@SherifWaly want to do this one? :D

I switched the approach - we're not gonna work with finite automata. It's too tedious work, the logic would be too complicated (iterate char by char and everything). Instead, we're gonna be working with lines :)

@SherifWaly
Copy link
Contributor

@amihaiemil Ok, I will try to do it :D

@0pdd
Copy link
Author

0pdd commented Feb 13, 2017

The puzzle 52-1a414e89 has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants