Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Single Line Sequences #489

Closed
LOOHP opened this issue Jan 26, 2022 · 6 comments
Closed

Support for Single Line Sequences #489

LOOHP opened this issue Jan 26, 2022 · 6 comments

Comments

@LOOHP
Copy link

LOOHP commented Jan 26, 2022

Are there plans to support Single Line Sequences? For example:

List:
    - [text, "MORE TEXT"]
    - ["^Second line of text$", *]

Right now, these are parsed as String/Scalars.

(I've also forked the repo to sort of get this working for personal use. Would love to pr if its ok)

@zoeself
Copy link
Collaborator

zoeself commented Jan 26, 2022

@LOOHP thank you for reporting this. I'll assign someone to take care of it soon.

@zoeself
Copy link
Collaborator

zoeself commented Jan 26, 2022

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@amihaiemil
Copy link
Member

@LOOHP yep, it's in the plan. The problem is, I haven't had so much time for eo-yaml recently. I think I even started to implement the Flow Reading for YamlMapping here (if I'm not mistaken, this {}/[] representation for mappings/sequences is called "flow").

Contributions are definitely welcome, but please try to follow the existing architecture. You'll notice the reading part looks a bit strange compared to what most developers are used to :D

@LOOHP
Copy link
Author

LOOHP commented Jan 27, 2022

I can see the difference in style :P
I will try my best to follow (if I do end up contributing).

@zoeself
Copy link
Collaborator

zoeself commented Apr 5, 2024

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@amihaiemil
Copy link
Member

This has been implemented and released with version 8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants