Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the role of the Deco binary? #4

Closed
namuol opened this issue May 25, 2016 · 9 comments
Closed

What is the role of the Deco binary? #4

namuol opened this issue May 25, 2016 · 9 comments
Labels

Comments

@namuol
Copy link

namuol commented May 25, 2016

What's the role of the Deco binary? Is the source for it available?

Full disclosure: I'm attempting to run Deco in Linux. :neckbeard:

@gdowens
Copy link
Contributor

gdowens commented May 25, 2016

Ah! It is a very poorly named file. This is essentially a cocoascripted cocoa app that is used to run scripts with sudo access. See desktop/handlers/upgradeHandler.js

@gdowens
Copy link
Contributor

gdowens commented May 25, 2016

Would be awesome if you get it working. I have looked at https://www.npmjs.com/package/electron-sudo before, might be the right way to go for running the postinstall again after an upgrade.

@namuol
Copy link
Author

namuol commented May 25, 2016

Hmm. Seems like we'd be better off avoiding the need for sudo in the first place, if possible.

I'm guessing this is mainly a requirement in OS X when modifying signed/system executables or something to that effect, yes?

@BHSPitMonkey
Copy link
Contributor

I was just working toward the same goal and hit the same roadblock. Hope one of us gets somewhere!

@gdowens
Copy link
Contributor

gdowens commented May 25, 2016

@namuol we install some things into the system path (watchman, node, etc) — those generally require sudo. You never know if someone has certain folder permissions set strangely as well, so it avoids the installer failing in those edge cases. Open to finding ways around sudo; I agree it is an annoyance.

@namuol
Copy link
Author

namuol commented May 25, 2016

There could be a path to install deco with npm, which would effectively require node to be installed in the first place. Other binaries (i.e. watchman) could just be dependencies in package.json, and would be executed with npm scripts.

It's probably safe to assume most React developers have node installed. :)

@gdowens
Copy link
Contributor

gdowens commented May 25, 2016

@namuol

True, however, we have seen interest from designers and some other non-dev types.

Perhaps we could include in the installer an optional "Environment Setup" step? Since Developers like to have more transparency into their environment and everyone else doesn't really want to deal with that stuff.

@namuol
Copy link
Author

namuol commented May 25, 2016

Hmm. Taking a step back: Why do watchman and node need to be system executables in the first place? Couldn't they just be bundled with Deco and run from its own installation location? i.e. ./<Deco>/libs/binaries/node

This would also have the benefit of ensuring the exact expected versions are being used to prevent environment inconsistencies.

@gdowens
Copy link
Contributor

gdowens commented May 25, 2016

Yeah, it's worth revisiting the install process entirely. Moving the discussion here #16

@gdowens gdowens closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants