Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In README, links to Bitcoin testnet explorer were updated #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

In README, links to Bitcoin testnet explorer were updated #112

wants to merge 1 commit into from

Conversation

imestin
Copy link

@imestin imestin commented Jul 11, 2019

The links for Decred (testnet) are still not working, because non of the block explorers I know about could find those transactions.

The Bitcoin links were not working, because blocktrail.com ceased operations.

@jrick
Copy link
Member

jrick commented Jul 11, 2019

The examples were done on testnet2 and decred is currently on testnet3, so they need to be entirely redone.

@imestin
Copy link
Author

imestin commented Jul 12, 2019 •
edited

I tried to recreate the transactions.

After I run ./bitcoin-cli -testnet getnewaddress

./btcatomicswap --testnet --rpcuser=user --rpcpass=AtomicSwap1234 initiate 2N8S4gAgJSY8G9fMmRoR2hoNprgRFWRFcT2 0.001
will result:
participant address is not P2PKH

@imestin
Copy link
Author

imestin commented Jul 13, 2019 •
edited

I tried to create a SegWit compatible address in Bitcoin-qt, that also didn't work.
tb1q3nw54nyj44eewnkswv2jtqhqrl7rpr2t7tqmm5

I'm still trying to figure this out, if I will have a solution I will post it here.

@jrick
Copy link
Member

jrick commented Jul 15, 2019

You need to generate p2pkh addresses (aka legacy). getnewaddress should let you specify the kind.

@imestin
Copy link
Author

imestin commented Jul 16, 2019 •
edited

OK, it works.

bitcoin-cli -testnet getnewaddress random_comment legacy
will work

@imestin
Copy link
Author

imestin commented Jul 16, 2019

signrawtransaction: -32: signrawtransaction was removed in v0.18. Clients should transition to using signrawtransactionwithkey and signrawtransactionwithwallet

@imestin
Copy link
Author

imestin commented Jul 16, 2019 •
edited

I will create an issue with the above mentioned problem.

UPDATE: there is already a pull request for that.
#109

@imestin imestin mentioned this pull request Jul 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imestin @jrick