Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getblocktemplate failure on startup due to bad txFees/sigOps structs #64

Closed
cjepson opened this issue Feb 27, 2016 · 3 comments
Closed
Labels

Comments

@cjepson
Copy link
Contributor

cjepson commented Feb 27, 2016

getblocktemplate fails when generating new work from an old block found in the blockchain in the absence of a cached template. This is caused by a bad declaration in mining.go.

fees: []int64{0}, sigOpCounts: []int64{0},

This can be fixed by calculating the fees and sigop number for these transactions.

@jcvernaleo jcvernaleo added the bug label Apr 11, 2016
@marcopeereboom marcopeereboom added this to the v0.3.0 milestone Jul 27, 2016
@marcopeereboom marcopeereboom assigned jcvernaleo and jolan and unassigned jcvernaleo Jul 29, 2016
@jolan
Copy link
Contributor

jolan commented Aug 8, 2016

Was starting to look into this and on testnet I just get -32603: race in block template data for getwork caused corruption over and over again.

getblocktemplate isn't used by anyone or anything as far as I know. Do we still want to fix it up?

@marcopeereboom marcopeereboom modified the milestones: future, v0.3.0 Aug 10, 2016
@marcopeereboom
Copy link
Member

Gated by: #130

@marcopeereboom marcopeereboom removed this from the future milestone Sep 23, 2016
@davecgh davecgh added this to the v1.1.0 milestone May 26, 2017
@davecgh davecgh modified the milestones: v1.1.0, v1.1.1 Sep 20, 2017
@davecgh davecgh removed this from the v1.1.1 milestone Dec 14, 2017
@davecgh
Copy link
Member

davecgh commented Mar 5, 2018

This is no longer relevant. The getblocktemplate call has since been disabled and any remaining issues will certainly be fixed when the mining code is redone. Closing.

@davecgh davecgh closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants