New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcserver: Add median time to verbose results. #2638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. This looks pretty good overall. Just a couple of inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I tested getblock
and getblockheader
, and they worked as expected. The JSON RPC API docs should probably also be updated to include the newly added field.
Good call. Agreed. |
Will update the docs. |
Median time is a useful value to return to clients, saving them the trouble of calculating it themselves. Include the value in verbose getblock and getblockheader results.
Added to docs/json_rpc_api.mediawiki in two places. I think that's sufficient? |
With the internal help, all phrases start with a lowercase "the" and end with a period. In the docs, they start with a capitalized "The" and have no ending punctuation. Just wanted to say that out loud. |
Yes, the changes look good. One for each of the two modified results.
This is correct. They both follow the standard practices for their respective function. Namely, the help output follows standard JSON-RPC practices while the API documentation follows standard API docs practices of using full grammatically-correct sentences. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval with JSON-RPC API documentation updates.
Median time is a useful value to return to clients, saving them the
trouble of calculating it themselves. Include the value in verbose
getblock and getblockheader results.
closes #2637