Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcserver: Add script version to gettxout. #2650

Merged
merged 2 commits into from May 13, 2021
Merged

rpcserver: Add script version to gettxout. #2650

merged 2 commits into from May 13, 2021

Conversation

JoeGruffins
Copy link
Member

closes #2647

@JoeGruffins
Copy link
Member Author

So, the version was moved from tylpes.GetTxOutResult to types.ScriptPubKeyResult?

davecgh
davecgh requested changes May 10, 2021
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the JSON-RPC API docs as well.

@davecgh
Copy link
Member

davecgh commented May 10, 2021

So, the version was moved from tylpes.GetTxOutResult to types.ScriptPubKeyResult?

Not really. They're different. The version that existed on types.GetTxOutResult was the transaction version, whereas this the script version.

@JoeGruffins
Copy link
Member Author

gettxoutreturns

rstaudt2
rstaudt2 approved these changes May 10, 2021
View reviewed changes
docs/json_rpc_api.mediawiki Show resolved Hide resolved
@itswisdomagain itswisdomagain mentioned this pull request May 11, 2021
Merged
@davecgh davecgh merged commit f993444 into decred:master May 13, 2021
@davecgh davecgh added this to the 1.7.0 milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstaudt2 rstaudt2 rstaudt2 approved these changes

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

rpcserver: Add Version field to gettxout.scriptPubKey results.
3 participants
@JoeGruffins @davecgh @rstaudt2