multi: Add CreateRevocationFromTicket. #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
reviewed
Aug 16, 2021
rstaudt2
force-pushed
the
create-revocation-from-ticket
branch
2 times, most recently
from
f8f44b5
to
a9a2f64
Compare
rstaudt2
force-pushed
the
create-revocation-from-ticket
branch
from
a9a2f64
to
30f6a42
Compare
JoeGruffins
approved these changes
Aug 26, 2021
rstaudt2
force-pushed
the
create-revocation-from-ticket
branch
from
30f6a42
to
4a358b4
Compare
davecgh
requested changes
Aug 26, 2021
This adds a new function, CreateRevocationFromTicket, and associated tests for creating a revocation transaction for a given ticket.
This reworks the createrawssrtx handler to use the CreateRevocationFromTicket function from the stake package rather than creating the transaction directly. It also adds additional error handling on the transaction input: - The input must be a ticket submission output (output index 0) - The input amount must equal the ticket submission amount
rstaudt2
force-pushed
the
create-revocation-from-ticket
branch
from
4a358b4
to
98608fb
Compare
matheusd
approved these changes
Aug 27, 2021
davecgh
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new function,
CreateRevocationFromTicket, and associated tests for creating a revocation transaction for a given ticket.Additionally, it reworks the
createrawssrtxrpcserverhandler to use theCreateRevocationFromTicketfunction from thestakepackage rather than creating the transaction directly.It also adds additional error handling on the transaction input:
This function will also be used from the mining template generation code to create revocations as part of the automatic ticket revocations agenda.