math/uint256: Prepare v1.0.0. #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstaudt2
approved these changes
Dec 8, 2021
dajohi
approved these changes
Dec 8, 2021
dnldd
approved these changes
Dec 9, 2021
This updates the docs/README.md file, module hierarchy graphviz, and module hierarchy diagram to reflect the new module.
While the original plan was to keep uint256 as a part of the primitives module, there has been interest in using the uint256 code now and the primitives module will not be complete and ready for release for quite some time. Also, after further discussion, the general preference is for a separate module that lives at math/uint256 for this code since the primitives module will ultimately be squarely aimed at Decred-specific things while math/uint256 is more generally useful, including many projects outside of Decred as well. Thus, this moves the new uint256 package from the internal staging area to math/uint256 where it will serve as a base for a new math/uint256 module release. Finally, it updates all relevant paths and package README.md accordingly.
davecgh
force-pushed
the
uint256_module
branch
from
2fb8f97
to
3b8efba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the original plan was to keep
uint256as a part of theprimitivesmodule, there has been interest in using theuint256code now and theprimitivesmodule will not be complete and ready for release for quite some time.Also, after further discussion, the general preference is for a separate module that lives at
math/uint256for this code since theprimitivesmodule will ultimately be squarely aimed at Decred-specific things whilemath/uint256is more generally useful by many projects outside of Decred as well.Thus, this moves the new
uint256package from the internal staging area tomath/uint256where it will serve as a base for a new v1.0.0math/uint256module release.Finally, it updates all relevant paths and package
README.mdaccordingly.