hdkeychain: alternate strict BIP32 child derivation method #2845
Conversation
chappjc
changed the title
chappjc
force-pushed
the
bip32std-child
branch
from
a5ed31b
to
e0f2da2
Compare
|
This is working with decred/dcrdex#1341, so setting ready for review. |
|
It occurred to me that https://github.com/decred/dcrd/blob/master/hdkeychain/doc.go could use a mention of the new method and how it differs from |
|
Good point. Probably the |
|
New text reads well. |
chappjc
force-pushed
the
bip32std-child
branch
from
34d2721
to
ec3ba65
Compare
chappjc
force-pushed
the
bip32std-child
branch
from
ec3ba65
to
6ce6d1e
Compare
|
You can squash it. Github has the ability to see changes on a rebase too. EDIT: I've reviewed the updates now too and they look good. |
| // Test for referential equality. | ||
| if pubKey != pubKey.Neuter() { | ||
| t.Errorf("Neuter of extended public key returned " + | ||
| "different object address") | ||
| return | ||
| continue |
There was a problem hiding this comment.
TestBIP0032Vectors provided the template for TestBIP0032Vector4, but it was cleanest not to force them into one test as vector 4 is specific to the difference between "standard" bip32 and our modified variant.
I updated the typo and the unnecessary return here though.
This creates a new ExtendedKey child derivation method, ChildBIP32Std, which creates an ExtendedKey with leading zeroes retained for strict compliance with BIP32. This is not intended for Decred wallet use.
chappjc
force-pushed
the
bip32std-child
branch
from
6ce6d1e
to
d508528
Compare
|
Updates look good to me as well. |
This creates a new child derivation method,
ChildBIP32Std, which createsExtendedKeyswith leading zeroes retained, and whos child derivation methods will generate private keys according to BIP32.