blockchain: Optimize stake node pruning. #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
May 10, 2022
rstaudt2
approved these changes
May 11, 2022
This exports the block index flush function to make it more consistent with the other funcs that are safe for concurrent access.
This adds an exported method to the block index to retrieve the best header node under the block index mutex and updates the various call sites that do it manually to use the newly exported function instead.
This optimizes the logic that prunes stake nodes when connecting blocks to make use of the best known header instead of the latest known checkpoint.
davecgh
force-pushed
the
blockchain_optimize_stakenode_pruning
branch
from
06954dd
to
bbccddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the logic that prunes stake nodes when connecting blocks to make use of the best known header instead of the latest known checkpoint.
While here, it also adds an exported method to the block index to retrieve the best header node under the block index mutex and updates the various call sites that do it manually to use the newly exported function instead as well as exports the block index flush function to make it more consistent with the other funcs that are safe for concurrent access.