blockchain: Fix revocation fee limit bug. #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This retroactively fixes a bug that resulted in the fee limit not being properly enforced for revocation transactions. The exploitation risk of this was that in a split transaction, one party could intentionally increase the fee paid to miners for another party. It is no longer possible to exploit this on mainnet since the automatic revocations agenda has activated, which enforces that the fee must be zero for revocation transactions. The fee limit for revocation transactions was never violated on mainnet so this logic can be safely corrected without impacting consensus. This has been validated by running a full sync with checkpoints and assume valid disabled.
davecgh
approved these changes
May 13, 2022
davecgh
added
the
non-forking consensus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retroactively fixes a bug that resulted in the fee limit not being properly enforced for revocation transactions. The exploitation risk of this was that in a split transaction, one party could intentionally increase the fee paid to miners for another party.
It is no longer possible to exploit this on
mainnetsince the automatic revocations agenda has activated, which enforces that the fee must be zero for revocation transactions.The fee limit for revocation transactions was never violated on
mainnet, so this logic can be safely corrected without impacting consensus. This has been validated by running a full sync with checkpoints and assume valid disabled.