standalone: Add transaction sanity check. #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_standalone_checktransactionsanity
branch
from
8a29adb
to
3309101
Compare
|
Thanks. Dex uses it. |
This was referenced May 14, 2022
JoeGruffins
approved these changes
May 19, 2022
This adds a new exported function to the blockchain/standalone module named CheckTransactionSanity which can be used to perform basic transaction sanity checks. It also updates the documentation and includes comprehensive tests. The primary motivation for this change is that there are several consumers that currently make use of this functionality and it lives in the blockchain package which is slated to made internal and therefore would otherwise become inaccessible to external consumers. Another nice benefit of making this logic available via the blockchain/standalone module is that it intentionally requires way less dependencies which is ideal for consumers.
davecgh
force-pushed
the
blockchain_standalone_checktransactionsanity
branch
from
3309101
to
0f26059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new exported function to the
blockchain/standalonemodule namedCheckTransactionSanitywhich can be used to perform basic transaction sanity checks.It also updates the documentation and includes comprehensive tests.
The primary motivation for this change is that there are several consumers that currently make use of this functionality and it lives in the
blockchainpackage which is slated to made internal and therefore would otherwise become inaccessible to external consumers.Another nice benefit of making this logic available via the
blockchain/standalonemodule is that it intentionally requires way lessdependencies which is ideal for consumers.