mempool: Store transaction descs in pools. #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
Nov 14, 2022
dnldd
approved these changes
Nov 14, 2022
Currently, several places that interact with the maps that house the raw transactions and staged transactions need access to the additional description data for the transaction in addition to the transaction itself. This involves an additional lookup and the need to pass around the map that houses that associated description data to perform the lookup. In order to avoid that additional lookup, passing around the associated map, and to simplify the code, this modifies those maps to store the overall transaction descriptions directly instead of the raw transactions and updates the various consumers accordingly.
davecgh
force-pushed
the
mempool_store_txdesc
branch
from
46fa8ec
to
ab226e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, several places that interact with the maps that house the raw transactions and staged transactions need access to the additional description data for the transaction in addition to the transaction itself. This involves an additional lookup and the need to pass around the map that houses that associated description data to perform the lookup.
In order to avoid that additional lookup, passing around the associated map, and to simplify the code, this modifies those maps to store the overall transaction descriptions directly instead of the raw transactions and updates the various consumers accordingly.