server: Bump supported wire pver for reject removal. #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the supported wire protocol version for the server to the version that indicates the reject message has been removed. This probably should have been done as a part of the v1.7.0 release so that peers would negotiate this version, but it wasn't, so rejecting older protocol versions will need to wait until this code is included in a release that also contains a consensus rule upgrade to piggyback on.
davecgh
force-pushed
the
multi_bump_wire_protocol_version
branch
from
1d1e769
to
8231d5a
Compare
davecgh
changed the title
dnldd
approved these changes
Nov 20, 2022
matheusd
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the supported wire protocol version for the server to the version that indicates the reject message has been removed.
This probably should have been done as a part of the v1.7.0 release so that peers would negotiate this version, but it wasn't, so rejecting older protocol versions will need to wait until this code is included in a release that also contains a consensus rule upgrade to piggyback on.
This completes the first part of #2546.