connmgr: Atomic connection request ID updates. #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates all accesses of a connection request's ID field to use its accessor func to ensure it is always accessed atomically.
This adds additional synchronization logic to the code that conditionally updates the ID of an existing connection request when one hasn't already been assigned to help prevent any potential logic races that could inadvertently be introduced in future code updates.
jrick
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all accesses of a connection request's ID field to use its accessor func to ensure it is always accessed atomically and adds additional synchronization logic to the code that conditionally updates the ID of an existing connection request when one hasn't already been assigned to help prevent any potential logic races that could inadvertently be introduced in future code updates.
It is split into individual commits for ease of review.