multi: Simplify threshold state determination. #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_simplify_threshold_state_determination
branch
from
edcb2dc
to
982c882
Compare
davecgh
force-pushed
the
blockchain_simplify_threshold_state_determination
branch
2 times, most recently
from
f773228
to
0184f0c
Compare
jholdstock
reviewed
Feb 25, 2023
davecgh
force-pushed
the
blockchain_simplify_threshold_state_determination
branch
from
0184f0c
to
b4e5a67
Compare
jholdstock
approved these changes
Feb 25, 2023
dajohi
approved these changes
Feb 25, 2023
JoeGruffins
approved these changes
Feb 27, 2023
This simplifies the internal logic for determining threshold states for various deployments by introducing a structure to house additional information about a deployment and passing that around as opposed to previous approach of passing around the information needed to lookup the relevant information and associated caches. The individual structs are created from the chain parameters and stored in a map when the chain instance is initialized.
This removes the deployment version parameter from the StateLastChangedHeight method on blockchain since it is no longer used and updates all callers accordingly.
This removes the deployment version parameter from the NextThresholdState method on blockchain since it is no longer used and updates all callers accordingly.
This removes the lookupDeploymentVersion method from the test harness along with the associated map since they are no longer used due to the removal of the deployment version parameter from NextThresholdState.
davecgh
force-pushed
the
blockchain_simplify_threshold_state_determination
branch
from
b4e5a67
to
f9f99b9
Compare
davecgh
deleted the
blockchain_simplify_threshold_state_determination
branch
davecgh
added
the
non-forking consensus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #3057.This simplifies the internal logic for determining threshold states for various deployments by introducing a structure to house additional information about a deployment and passing that around as opposed to previous approach of passing around the information needed to lookup the relevant information and associated caches.
The individual structs are created from the chain parameters and stored in a map when the chain instance is initialized.
It also removes the no longer needed deployment version parameters from the
StateLastChangedHeightandNextThresholdStatemethods as well as the no longer resulting unused internallookupDeploymentVersionmethod.This is work towards #3058.