[release-v1.7] main: Use backported peer updates. #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the go directive for the peer module to 1.17 which will allow the new module graph pruning and lazy loading capabilities introduced in Go 1.17 to be used once the updated modules are released. This means that, as described by the documentation, the go.mod file for the module now include a separate require block that includes all of the indirect dependencies.
This modifies the peer module to use the new formatting of doc comments in the Go 1.19 release.
This updates the max and default protocol version the peer package uses to the latest protocol version (wire.RemoveRejectVersion) and updates the tests to account for the removal of the reject message. It also adds a test that explicitly tests the handler on older protocol versions since the associated message is no longer sent on the latest one.
This updates AddKnownInventory and IsKnownInventory to use the concrete struct as opposed to a pointer to it in order to allow different instances of the struct to be used as a key versus needing to check with the same instance.
This updates the 1.7 release to use the latest version of the peer module which includes updates to use the latest protocol version by default and reduces bandwidth usage in certain scenarios by avoiding requests for inventory that is already known. In particular, the following updated module version is used: - github.com/decred/dcrd/peer/v3@v3.0.1
chappjc
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the 1.7 release to use the latest version of the
peermodule which includes updates to use the latest protocol version by default and reduces bandwidth usage in certain scenarios by avoiding requests for inventory that is already known.In particular, the following updated module version is used:
Note that it also cherry picks all of the commits included in updates to the
peer/v3module to ensure they are also included in the release branch even though it is not strictly necessary since thego.modhas been updated to require the newpeer/v3.0.1release and thus will pull in the new code. However, from past experience, not having code backported to modules available in the release branch too leads to headaches for devs building from source in their local workspace with overrides such as those ingo.work.