rpcclient: Explicitly require TLS >= 1.2 for HTTP. #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This set the TLS config to explicitly require TLS 1.2 as the minimum version for HTTP connections to explicitly match the requirement it imposes for WebSocket connections. This is technically a noop for the more recent Go releases that are officially supported since TLS 1.2 is the default minimum when acting as a client for those releases, however, it is preferable to be explicit and consistent.
davecgh
force-pushed
the
rpcclient_explicit_min_tls_ver
branch
from
9c43848
to
7f430e7
Compare
davecgh
changed the title
jrick
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set the TLS config to explicitly require TLS 1.2 as the minimum version for HTTP connections to explicitly match the requirement it imposes for WebSocket connections.
This is technically a noop for the more recent Go releases that are officially supported since TLS 1.2 is the default minimum when acting as a client for those releases, however, it is preferable to be explicit and consistent.