secp256k1/ecdsa: Expose r and s value of signature. #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
close #3187 |
|
I don't think unit test for getter is necessary. |
|
Thanks for the PR!
It's not strictly necessary, so I won't hold the PR up over it. I'll probably add one in a separate PR though because I noticed a code branch that isn't being hit while I was checking and I prefer to keep the cover as close to 100% as is possible. There are a couple of cases that are simply impossible to hit because they would require breaking the underlying crypto to compute. Before: After: |
davecgh
approved these changes
Sep 21, 2023
|
Do you have a preference for attribution in the overall dcrd release notes for the next release? I typically just use contributor's name displayed on their GitHub profile unless they request otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
R and S value can be useful for some computation, currently it is impossible to get R and S value from this package since it is unexported.
Closes #3187.