Ditch notifyjs #1867
Merged
Ditch notifyjs #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
force-pushed
the
ditch-notifyjs
branch
2 times, most recently
from
e3b2ebc
to
b78fff3
Compare
chappjc
force-pushed
the
ditch-notifyjs
branch
from
b78fff3
to
5f328e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This entirely removes the dependency on https://github.com/alexgibson/notify.js, which is an "archived" (dead) package.
Just use the
NotificationAPI. It's 2021 after all, and even android browsers are cool with it. We aren't doing anything fancy except displaying them briefly.This reduces the bundle size from 452 KiB to 449 KiB.