client/eth: Error fetching new swap status on testnet.

[JoeGruffins]

This is an error in the logs when trading on testnet. I do not think I have seen it on simnet, but maybe just missed it. Am not sure of its severity or if it matters. It looks to be a "problem" in geth, or our generated contract. I'm thinking it's safe to ignore. If there were a way to check for this particular error that would be good.

These are logs from a combined maker/taker node. The attempting to unmarshall an empty string while arguments are expected is what is unexpected. This is shortly after the match is made. As you can see here the next check a few seconds later is fine, and all checks after that.

2022-03-19 02:23:47.637 [TRC] CORE: Checking match 92ee130e6cb69db58a513957495419cd90dd31ec37be274bd484eb351d22fc65 (Taker) in status TakerSwapCast. Order: da81fb78b248a5900ca9856353accee5abfd80b3b264364331e6c6fd6c0952a0, Refund coin: , ContractData: 0000000049367dd0bf8976686855151acd3836d8a2da91769768ba42829099330d35048e, Revoked: false
2022-03-19 02:23:47.637 [TRC] CORE: Checking match 92ee130e6cb69db58a513957495419cd90dd31ec37be274bd484eb351d22fc65 (Maker) in status TakerSwapCast. Order: 0d52237b5b799d416c78d35543ce3ef05c4a7fa118be701f2cd4600d8c23cc4d, Refund coin: , ContractData: 6382012088c02049367dd0bf8976686855151acd3836d8a2da91769768ba42829099330d35048e8876a914d19752f030a8ff248d9c11c4e0eeab09c71aff346704b5573662b17576a91499f59d731f42a78aba9ba5523697928241f0b0d66888ac, Revoked: false
2022-03-19 02:23:47.639 [TRC] CORE: notify: |DATA| (match)
2022-03-19 02:23:52.356 [DBG] CORE: Unsubscribing from the dcr_eth order book for 127.0.0.1:17273
2022-03-19 02:23:53.027 [DBG] CORE[eth]: tip change: 6561905 (0xc1524730fede191c446326fa4baac4f76712cf8502cc8f5a42c03501ba9049b2) => 6561906 (0x40ee568656fe28434287dff8dc6322443afb26a76c6d7b889738e71d17907c4f)
2022-03-19 02:23:53.027 [TRC] CORE: processing tip change for eth
2022-03-19 02:23:55.029 [ERR] CORE: isRedeemable: error getting confirmation for our own swap transaction: error finding swap state: abi: attempting to unmarshall an empty string while arguments are expected
2022-03-19 02:23:55.029 [TRC] CORE: notify: |DATA| (match)
2022-03-19 02:23:55.029 [ERR] CORE: Failed to get confirmations of the counter-party's swap 27aab2da20025f3557af3b2a554753880f446fb4018d803f5fa60e828465c782 (eth) for match 92ee130e6cb69db58a513957495419cd90dd31ec37be274bd484eb351d22fc65, order 0d52237b5b799d416c78d35543ce3ef05c4a7fa118be701f2cd4600d8c23cc4d: error finding swap state: abi: attempting to unmarshall an empty string while arguments are expected
2022-03-19 02:23:55.585 [INF] CORE: Contract for match 92ee130e6cb69db58a513957495419cd90dd31ec37be274bd484eb351d22fc65 with swap coin 0x27aab2da20025f3557af3b2a554753880f446fb4018d803f5fa60e828465c782 (ETH) expires at 2022-03-19 19:22:45 +0900 JST (7h58m49s).
2022-03-19 02:23:55.585 [TRC] CORE: Checking match 92ee130e6cb69db58a513957495419cd90dd31ec37be274bd484eb351d22fc65 (Taker) in status TakerSwapCast. Order: da81fb78b248a5900ca9856353accee5abfd80b3b264364331e6c6fd6c0952a0, Refund coin: , ContractData: 0000000049367dd0bf8976686855151acd3836d8a2da91769768ba42829099330d35048e, Revoked: false
2022-03-19 02:23:55.585 [TRC] CORE: Checking match 92ee130e6cb69db58a513957495419cd90dd31ec37be274bd484eb351d22fc65 (Maker) in status TakerSwapCast. Order: 0d52237b5b799d416c78d35543ce3ef05c4a7fa118be701f2cd4600d8c23cc4d, Refund coin: , ContractData: 6382012088c02049367dd0bf8976686855151acd3836d8a2da91769768ba42829099330d35048e8876a914d19752f030a8ff248d9c11c4e0eeab09c71aff346704b5573662b17576a91499f59d731f42a78aba9ba5523697928241f0b0d66888ac, Revoked: false
2022-03-19 02:23:55.586 [TRC] CORE: notify: |DATA| (match)
2022-03-19 02:23:55.587 [TRC] CORE: notify: |DATA| (match)
2022-03-19 02:23:55.587 [DBG] CORE: Match 92ee130e6cb69db58a513957495419cd90dd31ec37be274bd484eb351d22fc65 not yet redeemable: current confs = 1, required confs = 12

[JoeGruffins]

Will look into this one.

[chappjc]

Looks like our 2 second timeout:

2022-03-19 02:23:53.027 [DBG] CORE[eth]: tip change: 6561905 (0xc1524730fede191c446326fa4baac4f76712cf8502cc8f5a42c03501ba9049b2) => 6561906 (0x40ee568656fe28434287dff8dc6322443afb26a76c6d7b889738e71d17907c4f)
2022-03-19 02:23:53.027 [TRC] CORE: processing tip change for eth
2022-03-19 02:23:55.029 [ERR] CORE: isRedeemable: error getting confirmation for our own swap transaction: error finding swap state: abi: attempting to unmarshall an empty string while arguments are expected

So it gets a new block notification, presumably including the contract (now mined), so the contract call should work. i.e. This is not an initial SwapConfirmations call prior to the swap tx being mined afaict. So maybe it just needs longer to process the block and unblock the CallContract cal in api/bind.(*BoundContract).Call