client/asset/{dcr,btc}: prevent swap broadcast on refund tx errors #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not broadcast swap(s) if there's any trouble generating or signing the refund txn(s).
chappjc
requested changes
Aug 24, 2021
chappjc
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Looks good. Works for me. @JoeGruffins a look from you would be good if you have a little time for it. It's reordering some operations around those pre-generated refund txns you added.
JoeGruffins
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not broadcast swap(s) if there's any trouble generating or signing
the refund txn(s).
Resolves #1163.