[release-v0.2] maintenance backports #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pseudo-upgrade was added prior to the first release and prior to schema versioning that would create the matches.forgiven column if it does not exist. It has existed in the CREATE TABLE statement since first release so this ALTER TABLE is always a no-op that just results in a logged NOTICE: [DBG] DB: pq: NOTICE (42701) - duplicate_column: column "forgiven" of relation "matches" already exists, skipping The comments around this indicate the same, that this should have been removed when actual upgrades were implemented. Schema v1 does indeed include this forgiven column, and this change can thus remove the ALTER TABLE statement that tries to re-add it on every startup.
…ecred#1323) Fix wrong asset for RequiredOrderFunds on market-buy
"execute" any epoch orders in DB that may be left over from unclean shutdown. Whatever epoch they were in will not be seen again.
JoeGruffins
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both the v0.3 and v0.4 stable branches of dcrdex are targeting the unreleased Decred 1.7 (dcrd/dcrwallet), this cherry-picks a handful of minor bug fixes for the 0.2 release branch.
This also adds two new commits to facilitate this backporting:
DCRD=dcrd-1.6 DCRWALLET=dcrwallet-1.6 ./harness.sh)