Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/webserver/site: dev dep updates with slash-div bootstrap fix #1354

Merged
merged 2 commits into from Dec 27, 2021

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Dec 15, 2021

This is intended to be a final bump of node devDependencies before the v0.4 release.

A separate commit changes the Node.js versions used in CI to 16 (LTS) and 17 (current) since v16 transitioned from current to LTS in https://nodejs.org/en/blog/release/v16.13.0/

Of note is the update of bootstrap from 4.6.0 to 4.6.1, since this includes a fix for the slew of slash-div warnings from sass dart.

Minor bumps:

  • @babel/{core,eslint-parser,preset-env}: 7.15.0 -> 7.16.5
  • css-loader: 6.2.0 -> 6.5.1
  • css-minimizer-webpack-plugin: 3.0.2 -> 3.3.1
  • eslint-plugin-import 2.24.2 -> 2.25.3
  • eslint-plugin-promise: 5.1.0 -> 5.2.0
  • eslint-webpack-plugin: 3.0.1 -> 3.1.1
  • mini-css-extract-plugin: 2.2.0 -> 2.4.5
  • sass: 1.38.1- -> 1.45.1
  • sass-loader: 12.1.0 -> 12.4.0
  • stylelint-webpack-plugin: 3.0.1 -> 3.1.0
  • webpack: 5.51.1 -> 5.65.0
  • webpack-bundle-analyzer: 4.4.2 -> 4.5.0
  • webpack-cli: 4.8.0 -> 4.9.1

Patch:

  • babel-loader: 8.2.2 ->8.2.3
  • bootstrap: 4.6.0 -> 4.6.1

Also, clean-webpack-plugin went from "4.0.0-alpha.0" to just 4.0.0, but these reference the same actual revision, just a new tag.

@chappjc chappjc added this to the 0.4 milestone Dec 15, 2021
@buck54321
Copy link
Member

@chappjc chappjc removed this from the 0.4 milestone Dec 17, 2021
@chappjc
Copy link
Member Author

chappjc commented Dec 17, 2021

Removed from 0.4 milestone as we're gonna skip this for RC1, but we can reconsider before final release if this shows no issues on master.

@chappjc chappjc marked this pull request as ready for review December 17, 2021 20:37
@chappjc chappjc changed the title client/webserver/site: final dep updates with slash-div bootstrap fix client/webserver/site: dev dep updates with slash-div bootstrap fix Dec 21, 2021
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm on node v14.18.2 forever because decrediton wants that, but building fine.

This is intended to be a final bump of node devDependencies for the v0.4
release.

Other than the bootstrap package, none of the updates affect the
contents of the generated site bundle since they are just the tooling
for webpack.

Of note is the update of bootstrap from 4.6.0 to 4.6.1, since this
includes a fix for the slew of slash-div warnings from sass dart.

Minor bumps:
- @babel/{core,eslint-parser,preset-env}: 7.15.0 -> 7.16.5
- css-loader: 6.2.0 -> 6.5.1
- css-minimizer-webpack-plugin: 3.0.2 -> 3.2.0
- eslint-plugin-import 2.24.2 -> 2.25.3
- eslint-plugin-promise: 5.1.0 -> 5.2.0
- eslint-webpack-plugin: 3.0.1 -> 3.1.1
- mini-css-extract-plugin: 2.2.0 -> 2.4.5
- sass: 1.38.1- -> 1.45.0
- sass-loader: 12.1.0 -> 12.4.0
- stylelint-webpack-plugin: 3.0.1 -> 3.1.0
- webpack: 5.51.1 -> 5.65.0
- webpack-bundle-analyzer: 4.4.2 -> 4.5.0
- webpack-cli: 4.8.0 -> 4.9.1

Patch:
- babel-loader: 8.2.2 ->8.2.3
- bootstrap: 4.6.0 -> 4.6.1

Also, clean-webpack-plugin went from "4.0.0-alpha.0" to just 4.0.0,
but these reference the same actual revision, just a new tag.
@chappjc
Copy link
Member Author

chappjc commented Dec 27, 2021

I think I'm on node v14.18.2 forever because decrediton wants that, but building fine.

Decrediton moved to Electron 15 (Node.js v16.5), so we should jive with that now. decred/decrediton#3571

@chappjc
Copy link
Member Author

chappjc commented Dec 27, 2021

This is working fine for me when rebased on release-v0.4, but we don't have to use it there yet.
For now just merging on master for more use.

@chappjc chappjc merged commit c890fae into decred:master Dec 27, 2021
@chappjc chappjc deleted the site-deps-bs461 branch December 27, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants