client/testing: Make simnet tests modular. #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
changed the title
JoeGruffins
force-pushed
the
testallsimnetassets
branch
3 times, most recently
from
01d3a7b
to
85c64c1
Compare
|
Tests for all assets are passing. eth sometimes fails, but I expect it's because transactions are not mined sometimes. Added a block multiplier to try and solve this. Two wallets added to the doge harness in order to test balance changes. This uses constants at the top of the file to choose assets. I thought this was simplest, but open to other ideas. |
buck54321
approved these changes
May 11, 2022
Because doge does not distinguish between different wallets, it is difficult to test balance changes when testing, especially if the node is mining. Add two wallets that don't do anything special to use in tests.
JoeGruffins
force-pushed
the
testallsimnetassets
branch
2 times, most recently
from
34538e7
to
8587fd6
Compare
Change the simnet harness tests to work with all currently supported assets.
JoeGruffins
force-pushed
the
testallsimnetassets
branch
from
8587fd6
to
89d0c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1565
edit: Not sure if it closes the issue because it also mentions loadbot. Removed the closing phrase.