Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: resolve eslint 8 dep errors with Node 18 #1617

Merged
merged 1 commit into from May 25, 2022

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented May 16, 2022

I hit some errors after updating to Node 18 (v16 and v18 are only supported now) that are actually related to eslint-config-standard that was not quite compatible with eslint 8 (or perhaps just the npm that ships with Node 18).

standard/eslint-config-standard#202
standard/eslint-config-standard#209

This updates the npm deps to resolve that.

This also gets CI running on Node.js 16 and 18, which are the LTS and "Current" versions supported: https://nodejs.org/en/download/

This resolves a build error encountered with Node 18, but is apparently
related to the version of eslint-config-standard we were using that was
not quite compatible with eslint 8.

 @babel/core                        ^7.17.2  →  ^7.17.10
 @babel/plugin-transform-runtime    ^7.17.0  →  ^7.17.10
 @babel/preset-env                 ^7.16.11  →  ^7.17.10
 @babel/runtime                     ^7.17.8  →   ^7.17.9
 @typescript-eslint/eslint-plugin   ^5.15.0  →   ^5.23.0
 @typescript-eslint/parser          ^5.15.0  →   ^5.23.0
 babel-loader                        ^8.2.3  →    ^8.2.5
 css-loader                          ^6.6.0  →    ^6.7.1
 eslint                             ^8.11.0  →   ^8.15.0
 eslint-config-standard             ^16.0.3  →   ^17.0.0      **** the important change
 eslint-plugin-import               ^2.25.4  →   ^2.26.0
 mini-css-extract-plugin             ^2.5.3  →    ^2.6.0
 sass                               ^1.49.7  →   ^1.51.0
 stylelint                          ^14.5.0  →   ^14.8.2
 stylelint-webpack-plugin            ^3.1.1  →    ^3.2.0
 ts-loader                           ^9.2.8  →    ^9.3.0
 typescript                          ^4.6.2  →    ^4.6.4
 webpack                            ^5.69.0  →   ^5.72.1

This also disables the eslint "object-shorthand" error.
We could use the "consistent" option instead of disabling since there
are only a handful of violations in that mode, but it seems silly.

@chappjc chappjc changed the title app: resolve eslint 8 dep errors with Node 8 app: resolve eslint 8 dep errors with Node 18 May 16, 2022
This resolves a build error encountered with Node 18, but is apparently
related to the version of eslint-config-standard we were using that was
not quite compatible with eslint 8.

 @babel/core                        ^7.17.2  →  ^7.17.10
 @babel/plugin-transform-runtime    ^7.17.0  →  ^7.17.10
 @babel/preset-env                 ^7.16.11  →  ^7.17.10
 @babel/runtime                     ^7.17.8  →   ^7.17.9
 @typescript-eslint/eslint-plugin   ^5.15.0  →   ^5.23.0
 @typescript-eslint/parser          ^5.15.0  →   ^5.23.0
 babel-loader                        ^8.2.3  →    ^8.2.5
 css-loader                          ^6.6.0  →    ^6.7.1
 eslint                             ^8.11.0  →   ^8.15.0
 eslint-config-standard             ^16.0.3  →   ^17.0.0
 eslint-plugin-import               ^2.25.4  →   ^2.26.0
 mini-css-extract-plugin             ^2.5.3  →    ^2.6.0
 sass                               ^1.49.7  →   ^1.51.0
 stylelint                          ^14.5.0  →   ^14.8.2
 stylelint-webpack-plugin            ^3.1.1  →    ^3.2.0
 ts-loader                           ^9.2.8  →    ^9.3.0
 typescript                          ^4.6.2  →    ^4.6.4
 webpack                            ^5.69.0  →   ^5.72.1

This also disables the eslint "object-shorthand" error.
We could use the "consistent" option instead of disabling since there
are only a handful of violations in that mode, but it seems silly.
@chappjc chappjc added this to the 0.5 milestone May 20, 2022
@chappjc chappjc merged commit fcea466 into decred:master May 25, 2022
@chappjc chappjc deleted the eslint8-fix branch May 25, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants