Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: upgrade btc min version required #1735

Merged
merged 1 commit into from Jul 31, 2022

Conversation

vctt94
Copy link
Member

@vctt94 vctt94 commented Jul 26, 2022

This PR upgrades bitcoin min version required from v0.19 to v0.21. It also adds a min descriptor version, if using descriptor wallets.

This was discussed at matrix.

@chappjc
Copy link
Member

chappjc commented Jul 26, 2022

Nice. Looks like what we need for 0.21, which had descriptor wallets, but not the listdescriptors RPC.

@vctt94
Copy link
Member Author

vctt94 commented Jul 26, 2022

just noted the error does not look good:

image

fixing it

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good except for maybe the comment as @chappjc said.

@chappjc chappjc added this to the 0.5 milestone Jul 31, 2022
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is still incorrect, but the code works as required.

@chappjc chappjc merged commit c60d6f2 into decred:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants